[examples] Use CCD for example scene#6159
Open
bakpaul wants to merge 3 commits into
Open
Conversation
bakpaul
added
pr: enhancement
Contributor
Author
|
[ci-build][with-all-tests] |
fredroy
force-pushed
the
26_06_use_ccd_in_falling_sofa_scene
branch
from
288c8f1 to
f4a9b24
Compare
hugtalbot
requested changes
Jun 18, 2026
hugtalbot
left a comment
hugtalbot
left a comment
Contributor
There was a problem hiding this comment.
It would be nice to have a dedicated scene example for CCD
Moreover, your change added a warning in the scene :
[WARNING] [CCDTightInclusionIntersection(CCDTightInclusionIntersection)] Required data "alarmDistance" has not been set. Falling back to default value: 1
Collaborator
|
[ci-depends-on] detected during build #4. To unlock the merge button, you must
|
Collaborator
|
[ci-depends-on] detected during build #5. To unlock the merge button, you must
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the CCD collision detection in the example scene to remove the bad looking skinning effect (not very good for showcasting).
The downside is that we have a 20% reduce in performances (on my computed we went from 240 fps to 190)
[with-all-tests]
[ci-depends-on https://github.com/sofa-framework/Regression/pull/115]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if